extremely deep stack during import
Submitted by Adam Dingle
Assigned to Jim Nelson
Link to original bug (#716009)
Description
---- Reported by adam@yorba.org 2010-03-08 07:58:00 -0800 ----
Original Redmine bug id: 1520
Original URL: http://redmine.yorba.org/issues/1520
Searchable id: yorba-bug-1520
Original author: Adam Dingle
Original description:
From Martin Olsson:
-
Are you aware that you're generating extremely deep stacks during modest to large imports (which will most likely give you a stackoverflow for imports of a certain size and up)? I've seen cases where Shotwell used stacks 40000 frames deep. In these cases the frames follow the following repeating pattern, i.e:
#9 (closed) 0x0000000000476896 in spin_event_loop () at src/util.c:1138
#10 (closed) 0x0000000000431ba2 in thumbnail_cache_import_thumbnails (photo_id=0x7fffffda4bd0, thumbnails=0x1b6188c0, force=1, error=0x7fffffda4be8) at src/ThumbnailCache.c:779
#11 (closed) 0x0000000000472620 in library_photo_import (photo_row=0x16cfb68, thumbnails=0x1b6188c0, photo=0x7fffffda4c28) at src/Photo.c:4513
#12 (closed) 0x000000000047b4ee in batch_import_on_import_file_completed (job=
<value optimized out>
, self=<value optimized out>
) at src/BatchImport.c:1639#13 _batch_import_on_import_file_completed_completion_callback (job=
<value optimized out>
, self=<value optimized out>
) at src/BatchImport.c:1548#14 0x00000000004d3411 in background_job_on_notify_completion (self=
<value optimized out>
) at src/Workers.c:566#15 (closed) _background_job_on_notify_completion_gsource_func (self=
<value optimized out>
) at src/Workers.c:535#16 0x00007ffff1ee9df2 in g_main_dispatch (context=0x7a5b20) at /build/buildd/glib2.0-2.23.4/glib/gmain.c:1960
#17 (closed) IA__g_main_context_dispatch (context=0x7a5b20) at /build/buildd/glib2.0-2.23.4/glib/gmain.c:2513
#18 (closed) 0x00007ffff1eedc38 in g_main_context_iterate (context=0x7a5b20, block=
<value optimized out>
, dispatch=<value optimized out>
, self=<value optimized out>
) at /build/buildd/glib2.0-2.23.4/glib/gmain.c:2591#19 (closed) 0x00007ffff1eede1c in IA__g_main_context_iteration (context=0x7a5b20, may_block=1) at /build/buildd/glib2.0-2.23.4/glib/gmain.c:2654
#20 0x00007ffff52047d1 in gtk_main_iteration () from /usr/lib/libgtk-x11-2.0.so.0
#21 0x0000000000476896 in spin_event_loop () at src/util.c:1138
#22 (closed) 0x0000000000431ba2 in thumbnail_cache_import_thumbnails (photo_id=0x7fffffda4e40, thumbnails=0x7fffd4664860, force=1, error=0x7fffffda4e58) at src/ThumbnailCache.c:779
#23 0x0000000000472620 in library_photo_import (photo_row=0x16cfa48, thumbnails=0x7fffd4664860, photo=0x7fffffda4e98) at src/Photo.c:4513
#24 0x000000000047b4ee in batch_import_on_import_file_completed (job=
<value optimized out>
, self=<value optimized out>
) at src/BatchImport.c:1639#25 (closed) _batch_import_on_import_file_completed_completion_callback (job=
<value optimized out>
, self=<value optimized out>
) at src/BatchImport.c:1548#26 (closed) 0x00000000004d3411 in background_job_on_notify_completion (self=
<value optimized out>
) at src/Workers.c:566#27 _background_job_on_notify_completion_gsource_func (self=
<value optimized out>
) at src/Workers.c:535#28 (closed) 0x00007ffff1ee9df2 in g_main_dispatch (context=0x7a5b20) at /build/buildd/glib2.0-2.23.4/glib/gmain.c:1960
#29 (closed) IA__g_main_context_dispatch (context=0x7a5b20) at /build/buildd/glib2.0-2.23.4/glib/gmain.c:2513
#30 0x00007ffff1eedc38 in g_main_context_iterate (context=0x7a5b20, block=
<value optimized out>
, dispatch=<value optimized out>
, self=<value optimized out>
) at /build/buildd/glib2.0-2.23.4/glib/gmain.c:2591#31 0x00007ffff1eede1c in IA__g_main_context_iteration (context=0x7a5b20, may_block=1) at /build/buildd/glib2.0-2.23.4/glib/gmain.c:2654
#32 (closed) 0x00007ffff52047d1 in gtk_main_iteration () from /usr/lib/libgtk-x11-2.0.so.0
#33 0x0000000000476896 in spin_event_loop () at src/util.c:1138
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:40:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 3 years ago
-
Priority deleted (
<strike>
_High_</strike>
)
Comment 2
Updated by Adam Dingle over 3 years ago
- Status changed from Open to Review
- Assignee changed from Anonymous to Jim Nelson
Comment 3
Updated by Jim Nelson over 3 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done set to 100
Comment 4
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:44 UTC ---
This bug was previously known as bug 1520 at http://redmine.yorba.org/show_bug.cgi?id=1520
Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Resolution: RESOLVED FIXED