Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • shotwell shotwell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 995
    • Issues 995
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • shotwellshotwell
  • Issues
  • #19

Closed
Open
Created Jul 12, 2018 by Ghost User@ghost

Batched add in DirectPhotoSourceCollection causes a long delay until switching to next photo is possible

When using Shotwell's direct-view to look at a photo in a directory which contains lots of photos and/or some raw-photos, it takes quite a long time until it is possible to click on the next-photo-button.

I could fix that by removing the array-list prepared_photos in DirectPhotoSourceCollection and made on_file_discovered call add of the base-class DataCollection for each file the monitor reports (see attached diff for details).

My girlfriend asked my to solve that annoying behaviour she encountered very often while editing photos. I could find and fix the problem very quickly for her with this patch. But I must admit that I did no in-deep-testing for regressions. Neither have I tried to find out why that batching was in place. (do the signal-handlers of notify_items_added or notify_contents_altered take that much time?) So maybe you have another idea to solve that problem?

direct-no-prepare.diff

Assignee
Assign to
Time tracking