Skip to content
  • Carlos Garnacho's avatar
    wayland: Cancel selection data sources that are set while unfocused · 4bee25d8
    Carlos Garnacho authored and Marge Bot's avatar Marge Bot committed
    If a client is naive enough to assume that it can set the selection while
    it has got no surfaces, mutter will simply ignore the request and leave
    the selection unchanged.
    
    This is good and the expected behavior, however the poor client that did
    this will enter in an inconsistent state where it "claimed" the selection,
    but nobody told it that the wl_data_source is not current.
    
    So, when the client is focused the next time, it will receive wl_data_offers
    as usual, but it will still think all the time that it is owning the
    selection. In the case of GTK, that takes client-side shortcuts, so any
    attempted paste will still bring back the client-side aborted selection.
    
    To fix this, cancel the selection right away if it happened while unfocused,
    the client will be able to undo its own failed selection, and not assume
    that future offers are its own.
    
    Fixes: GNOME/mutter#1469
    Part-of: <GNOME/mutter!1772>
    4bee25d8