Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • totem totem
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 191
    • Issues 191
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • totemtotem
  • Merge requests
  • !5

opensubtitles: Fix a function signature

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mathieu Bridon requested to merge mbridon/totem:fix-opensubtitles into master Jun 27, 2018
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 1

Commit 6afabc10 changed the method signature to please pylint:

-    def _show_dialog (self, params, _):
+    def _show_dialog (self, _):

This effectively makes the method take a single parameter instead of two.

However the method is typically called with two arguments. (it is an action callback)

This completely broke the OpenSubtitles plugin, which wasn't able to show its dialog any more.

This commit makes the code ignore all parameters of the method, so Pylint is still happy, but fixes the issue.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-opensubtitles