Skip to content

opensubtitles: Fix a function signature

Mathieu Bridon requested to merge mbridon/totem:fix-opensubtitles into master

Commit 6afabc10 changed the method signature to please pylint:

-    def _show_dialog (self, params, _):
+    def _show_dialog (self, _):

This effectively makes the method take a single parameter instead of two.

However the method is typically called with two arguments. (it is an action callback)

This completely broke the OpenSubtitles plugin, which wasn't able to show its dialog any more.

This commit makes the code ignore all parameters of the method, so Pylint is still happy, but fixes the issue.

Merge request reports