Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • totem totem
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 191
    • Issues 191
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • totemtotem
  • Merge requests
  • !319

opensubtitles: Re-enable menu item after Download

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Krifa75 requested to merge Krifa75/totem:reenable-opensubtitles into master Nov 24, 2022
  • Overview 7
  • Commits 1
  • Pipelines 3
  • Changes 1

After downloading a subtitle, the menu was disabled.

I adapted to the code but may I ask if there is any reason as to why the window is not modal ?

Also, would you like I create a template for the window and split each class into separate files ? It would be easier to maintain.

N.B: I don't know if you are aware but OpenSubtitles API has been deprecated for a REST API. His end-of-life will be end 2023 (if we're still alive until there).

Closes: #532 (closed)

Thanks

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: reenable-opensubtitles