Multiple errors and soft assertions for Save As... in direct-edit mode
Submitted by Jim Nelson
Assigned to cli..@..ba.org
Link to original bug (#718268)
Description
---- Reported by jim@yorba.org 2011-09-27 14:16:00 -0700 ----
Original Redmine bug id: 4194
Original URL: http://redmine.yorba.org/issues/4194
Searchable id: yorba-bug-4194
Original author: Jim Nelson
Original description:
Open a photo with direct-edit mode. Make a simple color change (saturation, etc.). Choose File -> Save As... Save to a new file. The following errors are logged on the console:
(shotwell:12068): Gtk-WARNING **: Unable to retrieve the file info for
file:///home/jim/Desktop/IMG_0210a.JPG': Error stating file
'/home/jim/Desktop/IMG_0210a.JPG': No such file or directory
V 12068 2011-09-27 14:08:22 [DBG] Photo.vala:3206: Saving transformed version of [1] /home/jim/Desktop/IMG_0210.JPG to /home/jim/Desktop/IMG_0210a.JPG in file format PHOTO_FILE_FORMAT_JFIF
V 12068 2011-09-27 14:08:25 [DBG] Photo.vala:3214: Setting EXIF for /home/jim/Desktop/IMG_0210a.JPG
V 12068 2011-09-27 14:08:25 [CRT] direct_photo_source_collection_reimport_photo: assertion `IS_DIRECT_PHOTO (photo)' failed
V 12068 2011-09-27 14:08:25 [CRT] editing_host_page_display_mirror_of: assertion `IS_PHOTO (starting_photo)' failed
`
Additionally, the window title still shows the old filename with an asterisk beside it (indicating unsaved changes).
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----
History
Comment 1
Updated by Lucas Beeler about 2 years ago
- Assignee set to Clinton Rogers
Clinton,
Since you've been dealing so effectively with direct-edit mode bugs over the last few days, I'm passing this one your way. Good luck, my friend!
Lucas
Comment 2
Updated by Clinton Rogers about 2 years ago
The line:
(shotwell:12068): Gtk-WARNING **: Unable to retrieve the file info for `file:///home/jim/Desktop/IMG_0210a.JPG': Error stating file '/home/jim/Desktop/IMG_0210a.JPG': No such file or directory
appears to be a variant of #4302 (closed), which, at the moment, is believed to not be our bug.
Still investigating the rest of these.
Comment 3
Updated by Clinton Rogers about 2 years ago
In DirectPhotoPage.vala, these lines:
// Fetch the DirectPhoto and reimport.
DirectPhoto photo = DirectPhoto.global.get_file_source(dest);
...seem to be the start of the problem - 'photo' is null here.
Comment 4
Updated by Clinton Rogers about 2 years ago
- Status changed from Open to Review
- % Done changed from 0 to 70
At least one error message is the result of #4302 (closed) and, as such, is blocked, but a patch has been submitted that fixes the critical assertions.
Comment 5
Updated by Clinton Rogers about 2 years ago
- Status changed from Review to 5
- % Done changed from 70 to 100
- Resolution set to fixed
Comment 6
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:56 UTC ---
This bug was previously known as bug 4194 at http://redmine.yorba.org/show_bug.cgi?id=4194
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.12
Resolution: RESOLVED FIXED