single click should no longer edit a tag name
Submitted by Lucas Beeler
Assigned to cli..@..ba.org
Link to original bug (#717974)
Description
---- Reported by lucas@yorba.org 2011-08-30 19:43:00 -0700 ----
Original Redmine bug id: 4076
Original URL: http://redmine.yorba.org/issues/4076
Searchable id: yorba-bug-4076
Original author: Lucas Beeler
Original description:
A single mouse-down event on a tag that's selected in the sidebar currently edits the name of the tag. This was fine when tags were flat, but with HTags it interferes with drag-and-drop. We should consider making a double-click the edit trigger instead of a single-click.
Related issues:
- related to shotwell - 4085: Non-rename rename winds up on the undo stack (Fixed)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----
History
Comment 1
Updated by Adam Dingle about 2 years ago
- Target version changed from 0.12 to 0.11.1
I agree we need to change this: I've also noticed the interference with drag and drop, and it will be even worse when we support multi-select (#2275 (closed)). I don't know that there's precedent in the GNOME world for a double click meaning a rename, however. I might be inclined to take a different path: if you want to rename a tag, you need to right click and choose Rename from a context menu, or press F2. That's how Nautilus works, by the way. Could we simply do that for 0.11.1?
Comment 2
Updated by Adam Dingle about 2 years ago
- Subject changed from Move from single-click editing to double-click editing of selected tags to single click should no longer edit a tag name
Comment 3
Updated by Lucas Beeler about 2 years ago
- Assignee set to Clinton Rogers
Agreed, Adam. Let's follow the lead of Nautilus here. Double-click to edit is an artifact of my growing up with the classic Mac OS, so while its expected for Lucas Beeler, it might not be expected for GNOME users at large.
Also assigning this ticket to Clinton, since he's almost finished his work on #3887 (closed) and it'd be great to have him work on a code-related ticket (as opposed to just docs) for 0.11.1.
Comment 4
Updated by Clinton Rogers about 2 years ago
- Status changed from Open to Review
Patch submitted via email.
As written, however, it introduces a UI inconsistency, since now events can be renamed with a single click, but tags (and future drag-source tree entries) can't be; please let me know if you'd like something different here.
Comment 5
Updated by Adam Dingle about 2 years ago
I think we should be consistent through the entire sidebar tree: a single click should no longer rename anything.
Comment 6
Updated by Clinton Rogers about 2 years ago
- Status changed from Review to 5
- Resolution set to fixed
Comment 7
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:54 UTC ---
This bug was previously known as bug 4076 at http://redmine.yorba.org/show_bug.cgi?id=4076
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.11.1
Resolution: RESOLVED FIXED