RAW Shotwell development not deleted when switching to Camera development
Submitted by Jim Nelson
Assigned to cli..@..ba.org
Link to original bug (#717914)
Description
---- Reported by jim@yorba.org 2011-09-19 13:38:00 -0700 ----
Original Redmine bug id: 4141
Original URL: http://redmine.yorba.org/issues/4141
Searchable id: yorba-bug-4141
Original author: Jim Nelson
Original description:
I imported RAW+JPEG straight from hard disk. When I switch them to Shotwell developer, it takes a while to create the Shotwell development. Then I switch back to Camera developer, which is quick. However, the Shotwell developers are still on disk. When I switch back to Shotwell developer, it's speedy, which tells me the Shotwell developments are being reused rather than regenerated.
I'm not sure if this is a feature or a bug. Certainly keeping them around is useful if the user changes their mind. However, it also means a lot of files will be left behind if the user changes a lot of files' developer.
Related issues:
- related to shotwell - 4207: RAW files in RAW+JPEG pairs aren't properly deleted (Fixed)
- related to shotwell - Feature #3078 (closed): Provide some user control over mimic generation (Fixed)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 1 year ago
-
Target version deleted (
<strike>
_0.12_</strike>
)
Comment 2
Updated by Jim Nelson 11 months ago
- Target version set to 0.14.0
Comment 3
Updated by Jim Nelson 11 months ago
- Category set to raw
Comment 4
Updated by Jim Nelson 11 months ago
- Subject changed from Shotwell mimic not deleted when switching to camera development to RAW Shotwell development not deleted when switching to Camera development
- Description updated (diff)
Comment 5
Updated by Jim Nelson 10 months ago
- Assignee set to Clinton Rogers
Comment 6
Updated by Clinton Rogers 10 months ago
- Status changed from Open to Review
- % Done changed from 0 to 50
Please look at [bug/4141-zap-raw-developments-on-developer-change](http://redm ine.yorba.org/projects/shotwell/repository/revisions/6696cd9dff791a0ef0e90c8a7 e6391342546638e) for this. If this passes submission, I'd like to use a similar technique for handling trashing of files in #4207 (closed).
Comment 7
Updated by Lucas Beeler 10 months ago
- Status changed from Review to Open
Hi Clint,
As discussed, let's fix the issue in which some of the _RAW_shotwell.jpg developer images aren't deleted and the regression that prevents RAW+JPEG pairs from being properly trashed.
Lucas
Comment 8
Updated by Clinton Rogers 10 months ago
To keep everyone following this in the loop, a recap:
- It turned out the improper deletion of paired JPEGs wasn't a regression from this patch, but already happening in trunk; it's been ticketed as #6238.
- A case in the original submission was discovered where the application would incorrectly handle raw files that did not have an attendant JPEG already.
This update should handle the latter case correctly now; please look at [bug/4141-zap-raw-developments-on-developer-change, SHA b11b1ab0bf8309f7d25059 97c55f01db2dd60aba](http://redmine.yorba.org/projects/shotwell/repository/revi sions/b11b1ab0bf8309f7d2505997c55f01db2dd60aba) .
One caveat: it does not handle the case where Shotwell inadvertently
creates multiple numbered Shotwell
developments (e.g.
name_of_raw_CR2_shotwell_1.jpg
, name_of_raw_CR2_shotwell_2.jpg
, etc), as
it only knows what the current development's filename is (via the backing
photo row). The multiple developments themselves are symptoms of another
bug and will be fixed separately.
Comment 9
Updated by Clinton Rogers 10 months ago
- Status changed from Open to Review
Comment 10
Updated by Lucas Beeler 10 months ago
Approved. Commit!
Comment 11
Updated by Clinton Rogers 10 months ago
- % Done changed from 50 to 100
- Resolution set to fixed
Comment 12
Updated by Clinton Rogers 10 months ago
- Status changed from Review to 5
Applied in changeset 6619b39d.
Comment 13
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:54 UTC ---
This bug was previously known as bug 4141 at http://redmine.yorba.org/show_bug.cgi?id=4141
Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.14.0
Resolution: RESOLVED FIXED