Import of generic video files fails
Submitted by an unknown user
Assigned to Lucas Beeler
Link to original bug (#717309)
Description
---- Reported by shotwell-maint@gnome.bugs 2011-03-22 15:49:00 -0700 ----
Original Redmine bug id: 3397
Original URL: http://redmine.yorba.org/issues/3397
Searchable id: yorba-bug-3397
Original author: Tobias Rapp
Original description:
When performing an import of video files that are not in QuickTime or AVI format the import fails. This seems to be some side-effect of the fix in #3357 (closed).
After wrapping the call to VideoReader.read_metadata() in LibraryFiles.vala with try-except similar to how it is done with photos import of generic video files works again.
(Added by jim:) This only occurs when the video file is being copied during the import.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Tobias Rapp over 2 years ago
Added a patch file showing my code changes.
Comment 2
Updated by Adam Dingle over 2 years ago
- Target version set to 0.9
- Priority set to High
Comment 3
Updated by Vera Yin over 2 years ago
Can you tell us which video files are being rejected without this patch?
Comment 4
Updated by Adam Dingle over 2 years ago
- Status changed from Open to Review
- Assignee changed from Anonymous to Jim Nelson
We can reproduce this with an .ogg file. Thanks very much for pointing this out and for the patch. This fix should just barely make 0.9.
Comment 5
Updated by Jim Nelson over 2 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done changed from 0 to 100
Thanks for the great catch!
r2799
Comment 6
Updated by Tobias Rapp over 2 years ago
Seems like the patch made it into the 0.9 release and branch but not into trunk.
Comment 7
Updated by Adam Dingle over 2 years ago
- Status changed from 5 to 4
-
Resolution deleted (
<strike>
_fixed_</strike>
) - % Done changed from 100 to 0
- Target version changed from 0.9 to 0.10
Indeed. Thanks for letting us know.
Comment 8
Updated by Adam Dingle over 2 years ago
- Status changed from 4 to Review
- Assignee changed from Jim Nelson to Lucas Beeler
Comment 9
Updated by Lucas Beeler over 2 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done changed from 0 to 100
Cherry-picked into master in commit 2e93f617
Comment 10
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:51 UTC ---
This bug was previously known as bug 3397 at http://redmine.yorba.org/show_bug.cgi?id=3397 Imported an attachment (id=261960)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.10
Resolution: RESOLVED FIXED