Improve video thumbnailing
Submitted by Jim Nelson
Link to original bug (#717208)
Description
---- Reported by jim@yorba.org 2011-01-05 15:56:00 -0800 ----
Original Redmine bug id: 3063
Original URL: http://redmine.yorba.org/issues/3063
Searchable id: yorba-bug-3063
Original author: Jim Nelson
Original description:
In the past, the video thumbnailing code in Shotwell used a FLUSH flag in the seek operation to get higher-quality thumbnails from certain codecs. However, this caused a hang when dealing with certain movies (see #3041 (closed)). Removing the FLUSH flag fixes the hang but causes ugly or black thumbnails in a number of videos.
One possible solution to this is to use the Totem thumbnailer (or whatever program is registered as the thumbnailer for a particular MIME type) instead of our own code.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Adam Dingle almost 3 years ago
Several possibilities here:
We could invoke totem-video-thumbnailer directly, assuming it's present on the user's system, which it should be.
To be more general, we could look up the appropriate thumbnailer for the video's MIME type in gconf and then launch it. It's not clear whether this would allow us to tell the thumbnailer not to draw sprocket holes, though, as we can when calling totem-video-thumbnailer directly.
totem-video-thumbnailer is able to use the FLUSH flag without hanging, so we could study its code carefully and imitate its behavior by using similar GStreamer calls.
We could simply do nothing, wait for the flush hanging bug to be fixed in GStreamer (https://bugzilla.gnome.org/show_bug.cgi?id=638781), then restore the FLUSH flag in our own code.
Comment 2
Updated by Eric Gregory almost 3 years ago
It looks like there's three video thumbnailers out there:
- ffmpegthumbnailer
- totem-gstreamer-video-thumbnailer
- totem-xine-video-thumbnailer
There are also aggregation thumbnailers such as rox-thumbnailer and thunar- thumbnailers.
Unfortunately the syntax of these programs varies a bit, so we'd need separate support for each one.
Comment 3
Updated by Adam Dingle almost 3 years ago
- Status changed from Open to 5
- Resolution set to fixed
- % Done changed from 0 to 100
We implemented this (see#3147). Closing.
Comment 4
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:49 UTC ---
This bug was previously known as bug 3063 at http://redmine.yorba.org/show_bug.cgi?id=3063
Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Resolution: RESOLVED FIXED