optionally exclude metadata when exporting
Submitted by Adam Dingle
Link to original bug (#716849)
Description
---- Reported by adam@yorba.org 2010-09-14 09:54:00 -0700 ----
Original Redmine bug id: 2556
Original URL: http://redmine.yorba.org/issues/2556
Searchable id: yorba-bug-2556
Original author: Adam Dingle
Original description:
A suggestion from Simon Spannagel simonspa@kth.se:
I want to propose another feature: I realized, that the actual export functionality of shotwell automatically exports all tags, ratings (and titles?) to the created files. I think this should be only an option and not the standard procedure - perhaps I could have some private tags which I don't want to share with others.
We could have a checkbox in the export dialog called "Export metadata", checked by default. If the user clears this checkbox, then we'll include no metadata in the export (including tags, titles or ratings), even metadata which was originally imported from JPEG files.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:40:00 -0700 ----
History
Comment 1
Updated by Adam Dingle about 3 years ago
- Priority set to High
Comment 2
Updated by Adam Dingle about 3 years ago
-
Priority deleted (
<strike>
_High_</strike>
)
Comment 3
Updated by Jules Kerssemakers about 3 years ago
After reading the privacy-related discussion on Launchpad (https://bugs.launchpad.net/ubuntu/source/shotwell/bug/579804), I'd like to add some suggestions here (I'm a bit of a privacy geek).
The LP discussion seemed to mostly about privacy issues (The “my garden†collection + geotags was a memorable example). To model this aspect, this feature could perhaps be split into levels, with a preference option allowing to set the default and a per-export override option.
To clarify: If I'm publishing the “my garden†collection, I'm probably okay with people knowing I took the shots on Nov. 9th 2010, !15 (merged):45h, that the pictures are tagged “my gardenâ€, “beautiful landscape†and taken by my Canon EOS 10000000DD.
I'm probably NOT okay with them knowing the location of my house (geotags) or the name of my girlfriend (people/face detection tags)
options:
strip all metadata from exported/published files
strip private(*) metadata from exported/published files
export all metadata
the (*)-item should answer something like “Which metadata is considered private?â€, obvious (to me) answers are:
- Geotags / geographic location
- all tags under the “People†tag (which isn't default by the way)
Thinking about it: some people would probably consider some metadata private that others are okay sharing. E.G. the camera model: maybe I don't want the world (and its thieves) to know I have a ten-thousand-dollar Canon EOS 10000000DD. If it was just a “!CrappyCo el Cheapo 1.3MPâ€, it's probably less of a problem.
A solution (though an overworked, un-Gnome-ish one) could be a list of checkboxes under the new metadata preference-tab where you can select which metadata categories you consider “privateâ€.
Kudos to Yorba for considering the first privacy-aware photo-manager!
Comment 4
Updated by Jonas Bushart over 2 years ago
I have written a small patch. I tried to change as little as needed.
The only opinion at the moment is to write all or write no metadata. But this can be easily extended.
Let's see how good this work is :)
Comment 5
Updated by Adam Dingle over 2 years ago
- Target version set to 0.11
- Priority set to High
Thanks for the patch. Lucas, can you review?
Comment 6
Updated by Lucas Beeler over 2 years ago
Thanks ever so much for your patch! This looks great! I am requesting one minor user interface tweak before we commit this patch, however. In most GNOME applications, the descriptive text for checkboxes and radio buttons is placed to the right of the actual button widget, not to the left. As an example of the conventional way of doing this, I've attached a screenshot captured from Shotwell's publishing dialog.
With your patch, however, the “Export metadata†explanatory text appears to the left of the checkbox widget. Could you please fix this such that the “Export metadata†text appears to the right, as is conventional?
Thanks,
Lucas
Comment 7
Updated by Jonas Bushart over 2 years ago
- File 0001-Enhancement-disabling-export-of-metadata.patch added
- File 0002-Fix-style-for-checkbutton-to-fit-to-GNOME-apps.patch added
- Description updated (diff)
@Lucas:
Nice, my first try in vala is good :)
I have fixed the little thing.
Also I changed the export call in th APIGlue.vala, because there is already a bool value called strip_metadata.
I uploaded a new patch against the new HEAD.
Comment 8
Updated by Lucas Beeler over 2 years ago
- Resolution set to fixed
Fixed in 5cde3441
Comment 9
Updated by Lucas Beeler over 2 years ago
- Status changed from Open to 5
Comment 10
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:47 UTC ---
This bug was previously known as bug 2556 at http://redmine.yorba.org/show_bug.cgi?id=2556 Imported an attachment (id=261814) Imported an attachment (id=261815) Imported an attachment (id=261816) Imported an attachment (id=261817)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.11
Resolution: RESOLVED FIXED