Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Files Files
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 537
    • Issues 537
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 42
    • Merge requests 42
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • FilesFiles
  • Merge requests
  • !746

Merged
Created Dec 20, 2021 by Matt Jakeman@firox263Contributor4 of 4 tasks completed4/4 tasks

Refactor out final uses of blocking dialogs

  • Overview 14
  • Commits 9
  • Pipelines 11
  • Changes 6

Replaces gtk_dialog_run() with equivalent non-blocking behaviour for the following files:

  • eel-stock-dialogs
  • nautilus-location-entry
  • nautilus-file-operations
  • nautilus-mime-actions
    • Partially complete, need to refactor activate_files

Opening now to get some feedback since the changes are more involved.

There is a bug with location-entry where the dialog is displayed twice, however this is also present in master.

I'm not sure how to go about porting mime-actions->activate_files(). I can think of either:

  • breaking it up into methods which are chained together, or
  • making the entire thing async and invoking a dialog on the main thread as we can then block on it.

Part of #1992 (closed)

Edited Dec 27, 2021 by Matt Jakeman
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 1992-refactor-dialogs