Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mutter mutter
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,103
    • Issues 1,103
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 123
    • Merge requests 123
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • muttermutter
  • Merge requests
  • !651

WIP: clutter/stage-cogl: Factor in pending_swaps to next_presentation_time [performance]

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Daniel van Vugt requested to merge vanvugt/mutter:schedule-later into master Jun 26, 2019
  • Overview 19
  • Commits 1
  • Pipelines 15
  • Changes 1

get_update_time was returning -1 in some cases even if schedule_update was called prior. So the master clock was overshooting the correct update time and missing some frames. This seems to be happening most under moderate CPU load (gnome-shell#1411 (closed)), but not so high a load as to justify the frame skips that were occurring.

The reason for get_update_time returning -1 in these cases was because it was considered impossible to calculate the next update time while pending_swaps > 0. That's not completely true. We know if pending_swaps == 1 then schedule_update should schedule one frame later. So just factor pending_swaps into schedule_update. Now get_update_time won't return -1 in these cases so we're more likely to render the next frame (or move the cursor) at the correct time.

Closes: gnome-shell#1411 (closed)

Prerequisite (just FYI for backporters): !216 (merged)

Edited Aug 06, 2019 by Daniel van Vugt
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: schedule-later