Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • M mutter
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 977
    • Issues 977
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 124
    • Merge requests 124
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • mutter
  • Merge requests
  • !305

Merged
Created Nov 13, 2018 by Daniel van Vugt@vanvugtContributor

clutter: Avoid redundant margin changes [performance]

  • Overview 4
  • Commits 1
  • Pipelines 2
  • Changes 1

When profiling gnome-shell it was found that one of the main triggers of clutter_actor_queue_relayout during animations was clutter_actor_set_margin_internal continuously setting the same zero margins. That's obviously pointless but also expensive since it incurs full stage relayouts and reallocation. So just avoid redundant margin changes.

Helps to further improve: #233 (closed), gnome-shell#349 (closed)

FIXME: This merged then got reverted. Needs a new MR.

Edited Nov 14, 2018 by Daniel van Vugt
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: avoid-pointless-margin-changes