Skip to content

Use GtkMenu instead GtkPopover outside GNOME

Tomasz Gąsior requested to merge (removed):classic-context-menus into gtk-3-22
  • GtkPlacesSidebar, GtkFileChooserWidget's treeview: convert plain menu items/buttons placed inside popovers to GMenu. It's more convenient and it is not needed to operate on bare widgets often.

  • GtkColorSwatch, GtkPlacesSidebar, GtkFileChooserWidget's treeview: use popover as context menu only inside GNOME. In other desktops use classic context menu (GtkMenu). Desktop is matched by XDG_CURRENT_DESKTOP env variable.

Important things:

  • Change in GtkPlacesSidebar breaks backwards compatibility in "populate-popup" signal. It seems to me it's not big problem — Nautilus is one known user of this feature and it's easy to fix it. I prepared patch for it, see comments.
  • I am not able to test GtkPlacesSidebar with libcloudproviders enabled. Help needed. ;)

csd-disabled

csd-enabled

Edited by Tomasz Gąsior

Merge request reports