Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gtk gtk
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1.6k
    • Issues 1.6k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 239
    • Merge requests 239
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gtkgtk
  • Merge requests
  • !82
The source project of this merge request has been removed.

Use GtkMenu instead GtkPopover outside GNOME

Closed Tomasz Gąsior requested to merge (removed):classic-context-menus into gtk-3-22 Mar 26, 2018
  • Overview 41
  • Pipelines 0
  • Changes 3
  • GtkPlacesSidebar, GtkFileChooserWidget's treeview: convert plain menu items/buttons placed inside popovers to GMenu. It's more convenient and it is not needed to operate on bare widgets often.

  • GtkColorSwatch, GtkPlacesSidebar, GtkFileChooserWidget's treeview: use popover as context menu only inside GNOME. In other desktops use classic context menu (GtkMenu). Desktop is matched by XDG_CURRENT_DESKTOP env variable.

Important things:

  • Change in GtkPlacesSidebar breaks backwards compatibility in "populate-popup" signal. It seems to me it's not big problem — Nautilus is one known user of this feature and it's easy to fix it. I prepared patch for it, see comments.
  • I am not able to test GtkPlacesSidebar with libcloudproviders enabled. Help needed. ;)

csd-disabled

csd-enabled

Edited Mar 31, 2018 by Tomasz Gąsior
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: classic-context-menus