Keyboard Shortcuts revamp followups
Followup issues from !1510 (merged)
-
There's a single headerbar across main view and sub-views, which is not how we usually do the deck/leafet pattern. Instead, there should be multiple headerbars attached to the actual views. This would also enable back gestures, which are currently not working. -
The search bar spacing looks good during scrolling, but it's unbalanced in the non-scrolling case (too much spacing below, not enough above). Could we make it dynamic, i.e. have more spacing above the search bar in the initial state, which shrinks as you scroll and the divider is added? If not, I'd go with a regular search bar here, with an always-visible divider and headerbar background color.
-
The dialog to actually set the shortcut should not be a dialog, but rather an inline deck/leaflet sub-view. That way it could also be closed in a more standard way (Esc-only is quite odd).
-
The search entry needs 6px horizontal margins on it, currently it's possible to resize the window to this:
-
The content of the custom shortcuts empty state view should be vertically centered
Edited by Tobias Bernard