timer: update UI to add edit, fullscreen, etc.
NOTE: I was told that this is too big of a PR. I'll close this and open a sequence of PRs addressing each issue by itself.
I've been working on an overhaul to the timer UI to suit (mostly) my personal needs by addressing these issues:
- fixes add fullscreen mode
- and display timer end time
- and maximize timer to full screen
- and Allow setting timer title in timer creation UI (Clocks 42.0)
- and Ability to edit timer by clicking on it
See the video demo (link below) to see the behavior / visuals.
This change required me to create a new timer-standalone.vala file containing patched code from around the project and of my own, so I added myself as the copyright holder at the top.
I had to change some interfaces in tiemr-item to get my functions working nicely, but I was able to merge everything with upstream; so there shouldn't be any issues.
All the phrases used in the files I changed should be compliant with GNOME's i18n standards (e.g. in UI files, labels are set to "translatable, and in Vala files, I'm using _("example")), but let me know if I'm missing something. The time format used to show the expacted ending time of each timer is also compliant with 12 and 24 hour formats.
When looking at the commit history, ignore anything on and before January 15th. I had previously made the mistake of committing to master in a previous contribution and had to revert it. This should explain all of those. Everything should be squashed on merge regardless, so that shouldn't matter.
minor bug
There is a minor bug that causes the timer pause animation to freeze in the following scenarios:
- Entering fullscreen on a timer that is paused from outside
- Anything that causes timer-rows to reorder (e.g. starting a short timer while a longer timer is paused)
As far as I can tell this is unrelated to my changes since the second scenario existed before (see this issue that I made).
I don't think fixing this should be part of this merge request for two reasons:
- I want this overhaul to be merged ASAP before my branch starts diverging even more.
- The issue existed before this contribution, and therefore should be fixed in a different merge request for the sake of organization.
Video Demo
Screenshots
Working with other locales / languages
If user uses 12-hour format:
RTL languages:
