Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • GIMP GIMP
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 4k
    • Issues 4k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 97
    • Merge requests 97
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GIMPGIMP
  • Merge requests
  • !750

Issue #8562: Fix odd length import/export for .ani metadata

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Alx Sa requested to merge alxsa-ani-fix into master Oct 03, 2022
  • Overview 14
  • Commits 1
  • Pipelines 6
  • Changes 2

This patch attempts to fix an issue noted in #8562 (closed). .ani file metadata (Author and Cursor names) must be an even length for Windows to recognize the file as valid. If the data itself is an odd length, then an extra 0x00 of padding is added per attribute (see attached sample images). Otherwise, the animation won't be visible when used as a cursor.

This patch adds a data length check to both the import and export code. It then reads in an "extra" byte or adds one, respectively. It also makes minor adjustments to the header size calculations to account for the potentially new byte(s).

Sample .ani files:

globe5.ani

WOMAN.ANI

XMAS.ANI

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: alxsa-ani-fix