Follow-up from "To fix some warnings" !451
The following discussions from !451 (merged) should be addressed:
-
@Jehan started a discussion: What is this gimp subproject inside GIMP? Could you remove it please?
-
@Jehan started a discussion: For consistency and better cross-platform code, let's keep glib types when we use it with glib code (even if it's usually typedef-ed to the same type as the one you'd expect). I.e. use
gulong
here. (cf.: https://developer.gnome.org/glib/stable/glib-Basic-Types.html#gulong) -
@Jehan started a discussion: Please align the variables, as per our coding style rules. This allows much faster code skimming for better maintenance.
-
@Jehan started a discussion: Align variables here too.
-
@Jehan started a discussion: Align variables here too.
-
@Jehan started a discussion: Align variables here too.
-
@Jehan started a discussion: Align variables here too.
-
@Jehan started a discussion: Align variables here too.
-
@Jehan started a discussion: Align variables here too.
-
@Jehan started a discussion: Please name the variable as per our coding style (lowercase, separated by underscore).
Although we sometimes declare several variables at once, we usually prefer one declaration for clarity, especially when you also initialize the variable in the same time.
-
@Jehan started a discussion: Align variables here too.
-
@Jehan started a discussion: Align variables here too.
-
@Jehan started a discussion: Align variables here too.