Skip to content

To fix some warnings

Marie-P requested to merge Marie-P/gimp:master into master

Hello, we are three computer students and we tried to fix some warnings. Hope this contribution will help.

 [91/1944] Compiling C object libgimpthumb/libgimpthumb-3.0.so.0.0.5.p/gimpthumb-utils.c.o
../libgimpthumb/gimpthumb-utils.c: In function gimp_thumb_init:
../libgimpthumb/gimpthumb-utils.c:170:10: warning: comparison of integer expressions of different signedness: gint {aka int} and guint {aka unsigned int} [-Wsign-compare]
  170 |        i < enum_class->n_values;
      |          ^
../libgimpthumb/gimpthumb-utils.c: In function _gimp_thumbs_delete_others:
../libgimpthumb/gimpthumb-utils.c:667:13: warning: comparison of integer expressions of different signedness: gint {aka int} and GimpThumbSize [-Wsign-compare]
  667 |       if (i == size)
      |             ^~
../plug-ins/common/file-gih.c:837:21: warning: comparison of integer expressions of different signedness: gint {aka int} and long unsigned int [-Wsign-compare]
  837 |       for (j = 0; j < G_N_ELEMENTS (selection_modes); j++)
      |                     ^
../plug-ins/common/file-gih.c:843:23: warning: comparison of integer expressions of different signedness: gint {aka int} and long unsigned int [-Wsign-compare]
  843 |         for (j = 0; j < G_N_ELEMENTS (selection_modes); j++)
      | 
../plug-ins/common/file-gif-save.c: In function special_flatten_indexed_alpha:
../plug-ins/common/file-gif-save.c:565:21: warning: comparison of integer expressions of different signedness: guint32 {aka unsigned int} and gint {aka int} [-Wsign-compare]
  565 |       for (i = 0; i < numpixels; i++)
      |                     ^
../plug-ins/common/file-gif-save.c:570:21: warning: comparison of integer expressions of different signedness: guint32 {aka unsigned int} and gint {aka int} [-Wsign-compare]
  570 |       for (i = 0; i < numpixels; i++)
      |   
../libgimpwidgets/gimpcolorarea.c: In function gimp_color_area_draw:
../libgimpwidgets/gimpcolorarea.c:400:21: warning: comparison of integer expressions of different signedness: gint {aka int} and guint {aka unsigned int} [-Wsign-compare]
  400 |       for (i = 0; i < priv->height; i++)
      | 
../libgimpwidgets/gimpcolorscale.c: In function gimp_color_scale_draw:
../libgimpwidgets/gimpcolorscale.c:344:21: warning: comparison of integer expressions of different signedness: gint {aka int} and guint {aka unsigned int} [-Wsign-compare]
  344 |       for (i = 0; i < priv->height; i++)
      |                     ^
../libgimpconfig/gimpconfig-utils.c: In function gimp_config_diff_same:
../libgimpconfig/gimpconfig-utils.c:98:17: warning: comparison of integer expressions of different signedness: gint {aka int} and guint {aka unsigned int} [-Wsign-compare]
   98 |   for (i = 0; i < n_param_specs; i++)
      |                 ^
../libgimpconfig/gimpconfig-utils.c: In function gimp_config_diff_other:
../libgimpconfig/gimpconfig-utils.c:127:17: warning: comparison of integer expressions of different signedness: gint {aka int} and guint {aka unsigned int} [-Wsign-compare]
  127 |   for (i = 0; i < n_param_specs; i++)
      |                 ^
../libgimpconfig/gimpconfig-path.c: In function gimp_config_path_expand_only:
../libgimpconfig/gimpconfig-path.c:548:25: warning: comparison of integer expressions of different signedness: gint {aka int} and guint {aka unsigned int} [-Wsign-compare]
  548 |           for (i = 0; i < n_substs; i++)
      |                         ^
../libgimpconfig/gimpconfig-path.c:552:17: warning: comparison of integer expressions of different signedness: gint {aka int} and guint {aka unsigned int} [-Wsign-compare]
  552 |           if (i < n_substs)
      |                 ^
../libgimpconfig/gimpconfig-path.c:634:25: warning: comparison of integer expressions of different signedness: gint {aka int} and guint {aka unsigned int} [-Wsign-compare]
  634 |           for (i = 0; i < n_substs; i++)
      |                         ^
../libgimpconfig/gimpconfig-path.c:659:17: warning: comparison of integer expressions of different signedness: gint {aka int} and guint {aka unsigned int} [-Wsign-compare]
  659 |   for (i = 0; i < n_substs; i++)
../libgimpbase/gimpprotocol.c: In function _gp_params_read:
../libgimpbase/gimpprotocol.c:1568:17: warning: comparison of integer expressions of different signedness: gint {aka int} and guint {aka unsigned int} [-Wsign-compare]
 1568 |   for (i = 0; i < *n_params; i++)
      |                 ^
../libgimpbase/gimpvaluearray.c: In function gimp_param_value_array_values_cmp:
../libgimpbase/gimpvaluearray.c:680:21: warning: comparison of integer expressions of different signedness: guint {aka unsigned int} and gint {aka int} [-Wsign-compare]
  680 |       for (i = 0; i < length1; i++)
      |                     ^
../libgimp/gimptilebackendplugin.c:239:25: warning: comparison of integer expressions of different signedness: gint {aka int} and guint {aka unsigned int} [-Wsign-compare]
  239 |       for (row = 0; row < gimp_tile.eheight; row++)


../libgimp/gimptilebackendplugin.c:284:25: warning: comparison of integer expressions of different signedness: gint {aka int} and guint {aka unsigned int} [-Wsign-compare]
  284 |       for (row = 0; row < gimp_tile.eheight; row++)
      |                         ^
../libgimp/gimpproceduredialog.c: In function gimp_procedure_dialog_fill_list:
../libgimp/gimpproceduredialog.c:1001:21: warning: comparison of integer expressions of different signedness: gint {aka int} and guint {aka unsigned int} [-Wsign-compare]
 1001 |       for (i = 0; i < n_pspecs; i++)
      |                     ^

../libgimp/gimpproceduredialog.c: In function gimp_procedure_dialog_fill_container_list:
../libgimp/gimpproceduredialog.c:1669:21: warning: comparison of integer expressions of different signedness: gint {aka int} and guint {aka unsigned int} [-Wsign-compare]
 1669 |       for (i = 0; i < n_pspecs; i++)
      |                     ^
../plug-ins/file-psd/psd-save.c: In function write_pixel_data:
../plug-ins/file-psd/psd-save.c:1532:59: warning: format %d expects argument of type int, but argument 2 has type gsize {aka long unsigned int} [-Wformat=]
 1532 |           IF_DEEP_DBG printf ("\t\t\t\t. ChanLenPos, len %d\n", len);
      |                                                          ~^     ~~~
      |                                                           |     |
      |                                                           int   gsize {aka long unsigned int}
      |                                                          %ld
../plug-ins/common/animation-optimize.c:622:26: warning: comparison of integer expressions of different signedness: gint {aka int} and guint {aka unsigned int} [-Wsign-compare]
  622 |               for (i=0; i<width; i++)
      |                          ^
../plug-ins/common/animation-optimize.c:627:34: warning: comparison of integer expressions of different signedness: gint {aka int} and guint {aka unsigned int} [-Wsign-compare]
  627 |                       for (j=0; j<num_colors[i]; j++)
      |                                  ^
../plug-ins/common/animation-optimize.c:675:22: warning: comparison of integer expressions of different signedness: gint {aka int} and guint {aka unsigned int} [-Wsign-compare]
  675 |           for (i=0; i<width; i++)
      |                      ^
../plug-ins/common/animation-optimize.c:680:26: warning: comparison of integer expressions of different signedness: gint {aka int} and guint {aka unsigned int} [-Wsign-compare]
  680 |               for (j=0; j<num_colors[i]; j++)
../plug-ins/metadata/metadata-editor.c: In function on_date_button_clicked:
../plug-ins/metadata/metadata-editor.c:945:28: warning: format %d expects argument of type int *, but argument 3 has type guint * {aka unsigned int *} [-Wformat=]
  945 |       sscanf (date_text, "%d-%d-%d;", &year, &month, &day);
      |                           ~^          ~~~~~
      |                            |          |
      |                            int *      guint * {aka unsigned int *}
      |                           %d
../plug-ins/metadata/metadata-editor.c:945:31: warning: format %d expects argument of type int *, but argument 4 has type guint * {aka unsigned int *} [-Wformat=]
  945 |       sscanf (date_text, "%d-%d-%d;", &year, &month, &day);
      |                              ~^              ~~~~~~
      |                               |              |
      |                               int *          guint * {aka unsigned int *}
      |                              %d
../plug-ins/metadata/metadata-editor.c:945:34: warning: format %d expects argument of type int *, but argument 5 has type guint * {aka unsigned int *} [-Wformat=]
  945 |       sscanf (date_text, "%d-%d-%d;", &year, &month, &day);
      |                                 ~^                   ~~~~
      |                                  |                   |
      |                                  int *               guint * {aka unsigned int *}
      |                                 %d

Merge request reports