Skip to content

Better flac metadata handling (wrong fields sizes array out of bounds crash fix)

Geoffrey Coulaud requested to merge GeoffreyCoulaud/g4music:master into master

In parse_flac_tags we read arbitrary data for the image mimetype length and image description length then use these values as array indexes. This can lead to out of array bouds reads that crash the app, so we always need to check before trying to access.

This check was done only for the image data, but it also needs to be done for all the arbitrary length metadata.

If you have questions, feel free to ask.

Edit: Fix for #11 (closed)

Edited by Geoffrey Coulaud

Merge request reports