Few issues with the meson port
I don't know how to give some constructive feedback on the meson port without a proper merge request, but I found few things:
-
https://gitlab.gnome.org/aruiz/gnome-terminal/-/blob/wip/meson/meson.build#L81-82
nautilus = dependency('libnautilus-extension', version: '>=3.28.0', required: false) nautilusextensiondir = nautilus.get_pkgconfig_variable('extensiondir')
This fails if thelibnautilus-extension
isn't available, thenautilusextensiondir
should probably moved inside a conditionif nautilus.found()
-
https://gitlab.gnome.org/aruiz/gnome-terminal/-/blob/wip/meson/po/meson.build#L3-4 Those two lines shouldn't be needed, i18n.gettext sets install to true by default already.
-
https://gitlab.gnome.org/aruiz/gnome-terminal/-/blob/wip/meson/data/icons/meson.build#L10-12 The convention is to use a post install script to update the icon cache, desktop database & compile the gsettings if there are any
-
https://gitlab.gnome.org/aruiz/gnome-terminal/-/blob/wip/meson/data/meson.build#L9 The po_dir is wrong here, as meson.current_source_dir returns ./data and not ./. The po_dir should be either defined at the top level of the project or use meson.source_root()
-
https://gitlab.gnome.org/aruiz/gnome-terminal/-/blob/wip/meson/data/meson.build#L4 The version here shouldn't be changed? it's the version of the spec and not the app version
-
The metainfo isn't installed with the meson build system
thank you for working on this =)