Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Podcasts Podcasts
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 105
    • Issues 105
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 17
    • Merge requests 17
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • World
  • PodcastsPodcasts
  • Merge requests
  • !120

Parse url login info into basic auth header

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Peter Rice requested to merge pvsr/podcasts:url-creds into master Sep 01, 2019
  • Overview 5
  • Commits 1
  • Pipelines 1
  • Changes 2

Fixes #124 (closed). Since hyper doesn't do anything with username:password in urls, we need to convert it to an Authorization header manually.

This will probably become unnecessary if/when !88 is merged, but I think this is worth having in the meantime. A good chunk of the podcasts I listen to are behind a basic auth wall, so this feature is vital for my use.

I don't know Rust very well, so apologies if this isn't idiomatic!

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: url-creds