Draft: error: Show toast instead of MessageDialog
Will switch out MessageDialog for Toast for error reporting. If there are transient windows stacked on top the current code will already send a notification instead, that prevents the toast getting missed stacked below other windows.
Right now clicking the button in the toast / clicking the notification will just open a MessageDialog, this should be replaced by a proper window with a scrollable view to be able to show the error in its entirety.
Advantages of using a Toast vs just MessageDialog:
- Will not randomly appear in front of the user
- Will not jump the window on top if the application is not focused
- As MessageDialog doesn't have enough space anyways and can't be made scrollable we need a separate window for the full error anyways. See eg. #384 (closed) for a long error that wouldn't appear in the backup status page either
Prior Art
GNOME Software
Checklist
-
Send a notification whenever the application is not focused instead of a toast nobody will see #332 -
Figure out whether to maybe just always send a notification and omit the toast completely -
Should the toast have a timeout? -
Implement proper error dialog -
Add entry to the CHANGELOG.md for non-trivial changes
Closes #183 Closes #384 (closed)
Edited by Fina Wilke