Skip to content

Fix duplicate albums

Philipp Wolfer requested to merge phw/lollypop:fix-duplicate-albums into master

This fixes issues with duplicate albums created on import since commit f75345aa .

Two cases are covered:

  • When creating an album for files with MusicBrainz album ID, the MB album ID was not saved, but used in duplicate check
  • When creating an album for files with empty or no MusicBrainz album ID, the duplicate check failed

Also this renames the field album.album_id to album.mb_album_id to avoid confusion and variable name conflict.

Tested with:

  • File import having MusicBrainz album ID tag set
  • File import without this tag
  • DB upgrade from before this commin
  • pre-commit checks successful

Due to this also having an upgrade method this PR will conflict with https://gitlab.gnome.org/gnumdk/lollypop/merge_requests/1291 . I will fix that whenever one PR got merged.

Edited by Philipp Wolfer

Merge request reports