Skip to content

Error request verification

Sonja Heinze requested to merge pitag/fractal:error-request-verification into master

Commit "Fix error handling of token request verification": Same situation for email token request verification and phone token request verification: Before, the user was always shown the error message "Couldn’t add the <email address / phone number.>", also when the error was due to the fact that the <email / phone> was already in use. That was due to the following deserialization error: The json reply of the query was deserialized into type EmailTokenResponse and type EmailTokenResponse only captured sid and did not capture errcode. So when matrix replied with an errcode, a deserialization error was triggered instead of capturing the errcode message. Therefore the attempt of the following lines of handling an errcode reply separately did not work and an errcode reply was handled in the same way as any other error.

With this commit, that bug is fixed: when the <email / phone> is already in use, the user is shown the error message "<Email / Phone number> is already in use"

Commit "Reload settings when verification dialog is closed": Closes #368 (closed) When a user wants to add a phone number or email addess, a verifikation token is sent to them and a dialog is opened to enter it. Before the commit, after closing the verification dialog, the settings dialog was not refreshed. Therefore the added <phone number / email adress> would stay in the input with a spinner spinning next to it until another action was taken.

With this commit, closing the verification dialog refreshes the settings window.

Merge request reports