Video player design review
The new video player is great overall, but the visuals still need some refinement. Some issues I noticed while testing, in no particular order:
In the media viewer, the videos resize weirdly at small sizes. Horizontally, they don't take up the entire width of the screen:
Vertically they are cut off instead of scaling:
The video player controls are too close to the edge, we should add some margins (I'd try 6px or 12px all around). Currently there's a small margin on the right, but none on the left, I'd make that even on all sides.
The audio icons are non-symbolic (which all UI icons should be), probably you can just append -symbolic
to their names to make them symbolic.
I'm also not sure if the transparent background is going to work like this, the standard GTK widget styling kind of assumes a background. We could probably make it work with some custom styling, but for now adding a semi-opaque background (like e.g. in Totem) is probably the easiest solutino.
This icon also looks non-symbolic:
This icon has a few issues:
- it's hard to see on light backgrounds (because there's no background or icon shadow)
- the border is not circular
- on hover the background is light, rather than dark (probably needs the OSD class?)
- there's a very light border around it
- it should be circular
- it needs some margins from the edges (I'd say 6px at the top and right)
I wonder if a permanent dark background, like behind the play button, would work better.
The popover doesn't have a fixed position, and seems to spawn wherever the cursor is when it clicks the button. Ideally, the point should be a few pixels below the icon and centered on it.
I was also wondering if speeding up the auto-playing video would be a good idea? It still feels a bit odd.