~/Documents/Bibliography path needs to be translated, but comment says don't
In src/entry_page.rs line 475, there is the following string:
self.imp()
.pdf_action_row
// NOTE Do not translate the path.
.set_subtitle(&gettext("Make sure ~/Documents/Bibliography exists"));
I'm assuming ~/Documents
is xdg-user-dirs' XDG_DOCUMENTS_DIR
. xdg-user-dirs' directory names can be translated and some are already. For instance, in pt_BR "Documents" is translated to "Documentos", so xdg-user-dirs creates the directory ~/Documentos
, not ~/Documents
. The same is true for other directories like Desktop, Downloads, Videos, etc.
Having that said, I believe "Documents" needs to be translated, otherwise it would be incorrect in localized systems. I assume that what should not be translated is "Bibliography" in the about path, right? (e.g. ~/Documentos/Bibliography
in pt_BR)
Having that said, I suggest:
- Make use of a placeholder like
~/Documents/{}
which in the built program results in "~/Documents/Bibliography" or respective translated version - Instead of having static
~/Documents
, would it be possible to fetch the translated Documents directory name? The commandxdg-user-dir DOCUMENTS
gives the user documents directory (e.g. /home/foobar/Documentos).