Skip to content

Fix timer not counting down to zero

Michael Evans requested to merge michaelgrahamevans/chess-clock:fix-time-not-reaching-zero into main

The timer is counting down to 1 second and then stopping with the following stack trace:

Traceback (most recent call last):
  File "/app/share/chess-clock/chess_clock/timer.py", line 68, in on_tick
    self.emit("changed", self.time)
TypeError: could not convert type float to guint64 required for parameter 0

The "changed" signal is an unsigned integer and so if the ChessClockTimer's count goes below zero then it cannot be emitted. This change ensures the count does not go below zero.

Merge request reports