Skip to content

Minor improvements around styles

Gonçalo Silva requested to merge github/fork/goncalossilva/ft.styles into master

This PR improves a couple of areas around styling.

The most important is related with the first PR I sent. At that point, I was unaware that properly built GTK themes export a small set of public colors for apps to use. I hard-coded these in each GTK theme CSS file unnecessarily.

Secondly, it splits gtk/web CSS into separate folders. This was done because of UberWriter now showing the default CSS file/folder in the advanced export screen -- in this context, only web CSS makes sense. To avoid confusing users, the split ensures that they will only see CSS files that are relevant in that context.

Lastly, it moves text view padding back to Python, where it was originally. I wrongly presumed that props.top_margin included padding set in CSS, which is not the case. That is added on top of everything else. This, in turn, broke scrolling calculations on very specific edge cases that I bumped into later on.

Merge request reports