Skip to content

Various improvements

Gonçalo Silva requested to merge github/fork/goncalossilva/various_improvements into various-improvements

This PR includes various fixes and improvements, most of which I discussed with @somas95 a couple of weeks ago. It also includes some refactoring, mainly to improve encapsulation.

Fixes #17 (closed)
Fixes #75 (closed) Fixes #90 (closed) Fixes #120 (closed) Fixes #122 (closed)

Some considerations/questions follow.

Commit messages I recommend reviewing each commit message carefully, as they explain the thinking behind each change. Not everything is small or linear, and hopefully the commit message explains the background and reasoning properly. If anything is missing, I'm happy to try to explain.

Translations There are a few capitalization/copy fixes. I am unsure how this affects translations, or if there's any work I can to make the transition easier. For instance, how are the po files updated?

Styling Styling is subjective, and although I claim to address #90 (closed), it's important to note that I'm a fan of UberWriter's simplistic style, reminiscent of iA Writer's approach. As such, I didn't introduce any sizing nor color changes, as I don't personally agree with this direction. Instead, the changes are subtle:

  • For links, the link/syntax part is greyed out, without any further changes
  • For code blocks, they are indented similarly to quotations, without any further changes

UI changes There are (very minor) UI changes within the places that were touched, mainly preferences and the export dialog. Most of these are around improving small things, such as spacing (eg. multiples of 8), slightly broken alignments, etc.

The only exception would be the removal of ODT as one of the export options in the top bar. As before, subjective, but I find that a sub-window's top bar with 6 horizontal buttons is a little overwhelming, and considering that ODT is still available within the advanced tab, I propose that we remove it as a default option and have a more balanced top bar. I am assuming that PDF/HTML are the most used, but please let me know if that's not the case.

Further work I have a few more tasks planned for the upcoming weeks, hopefully built on top of this codebase as it makes some of them much easier. Here's a screenshot of my Todoist. Hopefully this helps knowing what to expect. 😊

Merge request reports