Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • S squeekboard
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 129
    • Issues 129
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • World
  • Phosh
  • squeekboard
  • Merge requests
  • !582

popover: Deactivate settings button when lock screen is on

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged dcz requested to merge saver into master Dec 08, 2022
  • Overview 7
  • Commits 9
  • Pipelines 2
  • Changes 13

This won't work if the lock screen activates while the popover is active, but solving that would be a bunch of work again.

It won't compile on Byzantium due to zbus being several versions behind. It should compile on Crimson, because bookworm carries a sufficient version.

This MR contains a couple of themes:

  • try to make the loop/actor idea clearer, more loosely coupled, and/or more consistently applied (actors::external, popover state rework, Void type, Destination trait)
  • add a dbus listener actor
  • add a thread-safe wrapper for Rust objects in C (we can hopefully drop that once we bypass C)

Most commits are tiny (yay), and add a new function that stands alone.

I wanted to add a test binary to have the screensaver listener actor run standalone, but it's hassle to have it between Cargo and having to conditionally compile it. It's simple enough that it can be rewritten as needed.

Draft because it actually relies on an interface that doesn't work.

No draft: still useful even if not in effect yet.

Edited Dec 21, 2022 by dcz
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: saver