Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • S squeekboard
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 129
    • Issues 129
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • World
  • Phosh
  • squeekboard
  • Merge requests
  • !565

state: Don't animate when force-hidden

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged dcz requested to merge dcz/squeekboard:hide into master Jul 08, 2022
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

Steps to reproduce:

  1. Focus an input field (yad --entry)
  2. Force hide panel with dbus
  3. Focus no input field

Actual result: panel blinks

Expected: Panel stays hidden

The reason this was glitched is that defocusing clears the temporary "force hide" flag, and hiding is animated based on defocus time.

The fix is to lie about the defocus time and push it way into the past, where the animation was already played.

An alternative fix without lying would be to remember the time of clearing the force hide, and suppressing animations if the clear time was recent enough. That's more complicated though, and the focus time is only stored for animation in the first place. Alternative fix: explicit "inactive since forever" state, but that would add extra branches in state management for little benefit.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: hide