Skip to content

wifi-hotspot-quick-setting: Make sure 'state' signal gets disconnected

Guido Günther requested to merge guidog/phosh:hotspot-crash into main

The WifiManager outlives the quick setting (which might get added / removed at runtime when enabling disabling quick settings) we hence need to make sure we disconnect the signal when the quick setting goes away. Do so by using g_signal_connect_object.

This fixes that looks like

  #0  0x00005652da08fc4f in PHOSH_IS_STATUS_ICON (ptr=0x21) at ../src/status-icon.h:15
  #1  phosh_status_icon_set_info (self=0x21, info=0x7f5429c09061 "Hotspot Off") at ../src/status-icon.c:377
  #2  0x00007f5429c0851f in update_info (self=0x565300804880) at ../plugins/wifi-hotspot-quick-setting/wifi-hotspot-quick-setting.c:80
  #7  0x00007f542c0fffc3 in <emit signal 'notify:state' on instance 0x5652fd787d90 [PhoshWifiManager]>

I've checked we don't have other plugins with the same issue.

It'd be happy about a review so we can backport this to the 0.41.x branch

/cc @arun-mani-j

Merge request reports