Skip to content

media-player: Support data: URIs for album art

Jesús Higueras requested to merge granpc/phosh:jesus/mpris-album-art-data-uri into main

Some applications, such as Telegram Desktop, do not write album art to a file on disk. Instead, they pass a data: URI with a base64-encoded image.

We did not support this, so in these cases, all tracks played in apps like that would appear to have no cover art. This MR addresses that.

Code review notes:

  • I moved the "no cover art" fallback before the if statement so that we don't have to repeat the line in each failure branch of the decoding code
  • We do not use g_autoptr for the pixbuf loader because we already call its close function, which is necessary for decoding to work.

Merge request reports