Skip to content

lockscreen-plugins-calendar: encapsulate calendar to include ui file

Chris Talbot requested to merge kop3161/phosh:wip/cal into main

Per my thoughts earlier:

While the calendar plugin is useful to show how simple it is to make a lockscreen plugin, I honestly thought it was too simple, and I struggled to figure out how to expand it. In the end, I ended up modifying the ticket-box to suit my needs.

I created this MR so others can get started a bit quicker, in that all of the parts are there to expand the GUI right away, similar to how GNOME Builder makes their Hello World! GUI.

I made three commits in increasing complexity on purpose, so we could discuss what makes sense to include:

  • The GtkCalendar alone
  • The GtkCalendar inside a GtkBox
  • Added CSS

I personally like GtkCalendar inside a GtkBox, as this is the most extendable right away. However, if you desire the plugin to be merged back into Phosh, I think having the CSS makes sense so that the needed consistent CSS is there already.

As a side effect, this also makes the calendar plugin visually consistent with the rest of the plugins.

Edited by Chris Talbot

Merge request reports