Skip to content

media-player: Check type past the async result check

Guido Günther requested to merge guidog/phosh:media-player-async into main

Another media-player fix:

When the media-player gets disposed before getting the bus self is no longer valid. So be carful to not access it before we checked the async calls result.

This fixes sporadic test failures like

  37/42 phosh:integration / monitor-manager         FAIL            1.28s   killed by signal 5 SIGTRAP
  ...
  (/builds/guidog/phosh/_build/tests/test-monitor-manager:2065): phosh-media-player-CRITICAL **: 10:05:41.572: on_bus_get_finished: assertion 'PHOSH_IS_MEDIA_PLAYER (self)' failed

The other async callbacks were changed in 36a8c401 already.

Fixes 36a8c401 ("media-player: Use cancellable")

Signed-off-by: Guido Günther guido.gunther@puri.sm

Merge request reports