Skip to content

Simplify KeyGrabbing

Guido Günther requested to merge guidog/phosh:simplify-accelerator into main

Prompted by !1005 (closed) and !999 (merged) I had another look at the key grabbing code and I think and think keeping the allocation of AcceleratorInfo local to grab_single_accelerator and just passing back the action_id avoids further surprises (and fixes the same leak @sc0w fixed in another function handle_grab_accelerator() as we don't have to worry what to free exactly.

@sc0w I pulled your original patch into this MR (keeping your authorship) so your credit doesn't get lost but I think we can close !1005 (closed) .

/cc @devrtz as the original author or the grabbing code in case I have missed something.

Merge request reports