Skip to content

Properly namespace view related methods and other improvements

Guido Günther requested to merge guidog/phoc:view-cleanups into main

We only had parts of the public methods of PhocView namespaced with phoc_ which not only trips up gi-docgen but is also confusing to read. Fix that and while at that make keybinding generation more flexible by allowing for a parameter plus other improvements:

* d/control: Update URL

  While at that fix th section and update the standards version
  
* view: Prefix view_unmap

  No functional change.
  
* view: Prefix view_is_ getters

  This makes them show up in the docs
  
* view: Don't leak view arrangement

  Instead of leaking the details how view are layed out keep that
  local to view.
  
* keybindings: Avoid self for keybinding

  The objects is PhocKeybindings do don't use self for a
  single keybinding to avoid confusion.
  
* keybindings: Allow for a parameter

* keybindings: Use a single handler to move a view

* view: Prefix move_to_next_output

  It's a public function
  
* keybindings: Use a single handler to tile a view

* view: Prefix view_restore

  It's a public function
  
* view: Make view_center private

  We only need phoc_view_arrange() to be public. We add a forward
  declaration to avoid the code move.
  
* view: Prefix view_tile

  It's a public function
  
* view: Prefix view_automaximize

  It's a public function
  
* view: Prefix view_get_box

  It's a public function
  
* view: Prefix window decoration related functions

  They're currently all public
  
* view: Reindent function declarations

  Finally make it consistent with the other headers.
  
* doc-check: Make namespace check more strict

  The only bits not properly namespaced are wlroots signal handlers that
  are located in other compilation units.
  
* keybindings: Prefix parse_accelerator

  It's a public function
  
* gtk-shell: Make phoc_gtk_{shell,surface}_from_resource static

  No need to have them public.

Merge request reports