Skip to content

Make more bits of PhocView private

Guido Günther requested to merge guidog/phoc:view-private into main

Some of the variables are almost exclusively used in PhocView itself. Make them private.

  • view: Nuke view type
  • view: Make alpha private
  • view: Make scale private
  • view: Add type check asserts to public functions
  • view: Make view decoration private
  • view: Reindent state getters
  • view: Make state private

Kept reindent to a minimum. I'll add the 0.26.0 milestone as this would be great to land in preparation for other changes.

There's some more mechanical things like toplevel listeners but let's land this (and the dependencies (!423 (merged), !422 (closed), !421 (merged)) first.

Edited by Guido Günther

Merge request reports