Dark Mode Toggle Doesn't Do Anything
There is a toggle in the Preferences for whether or not Fragments should use Dark Mode. It does not appear to do anything.
I was curious what would happen if I changed the source code so that Fragments would just use the system theme (I'm using a very lightly modified version of Adwaita Dark), so I commented out the explicit call to adwaita.css
, and Adwaita Dark seems to work perfectly fine.
I also tried commenting out the references to Dark Mode within the code, so as to remove the non-functioning toggle, and I was able to do so without incident.
You can see my modifications to the code here: elsiehupp/Fragments@d9f734e6
I recognize that you are a signatory to Please Don't Theme, which I assume is why you hardcoded adwaita.css
, and indeed I found Fragments from their list of signatories. I appreciate that you have put in the work to build a native GNOME application.
I recognize that deferring to the system theme runs the risk that distributions will use severely broken CSS themes. It may be possible to parse the default GtkCssProvider
to see if it's a variant of Adwaita and default to a hardcoded version of Adwaita if it is not. I don't immediately know how to do that, but I can look into it. What do you think?