Skip to content

eds: Port to libecal-2.0

Milan Crha requested to merge wip/mcrha/eds-libical-glib into master

Once GNOME/evolution-data-server#33 (closed) is committed, please review and merge these changes. The referenced libecal version is 3.33.1, which will surely change, thus it'll need fixing before committing.

Please note that this branch is based on top of gnome-3-28 branch (I'm attaching the patch also here), because I've not been able to build the git master at all (at commit 0560981b) due to:

a) the configure fails with:

   Dependency gtk4 found: NO (tried pkgconfig)
   meson.build:152:0: ERROR:  Dependency "gtk4" not found, tried pkgconfig

   That's fixable, I changed the "gtk4" to the expected "gtk+-4.0" in the meson.build.

b) after the fix of the gtk4 reference the build fails with:

   ../plugins/all-tasks-panel/gtd-all-tasks-panel.c:46:3: error: unknown type name ‘GtkFilterListModel’
      GtkFilterListModel *filter_model;
      ^~~~~~~~~~~~~~~~~~
   ../plugins/all-tasks-panel/gtd-all-tasks-panel.c:47:3: error: unknown type name ‘GtkSortListModel’
      GtkSortListModel   *sort_model;
      ^~~~~~~~~~~~~~~~
   ../plugins/all-tasks-panel/gtd-all-tasks-panel.c: In function ‘on_clock_day_changed_cb’:
   ../plugins/all-tasks-panel/gtd-all-tasks-panel.c:281:3: warning: implicit declaration of function ‘gtk_filter_list_model_refilter’; did you mean ‘gtk_file_filter_filter’? [-Wimplicit-function-declaration]
      gtk_filter_list_model_refilter (self->filter_model);

   .......

   which I do not know how to fix. This is with gtk4 3.94.0.

I'm fine to provide the patch for the master branch, there are not that many new changes in the eds plugin with compare with the gnome-3-28 branch, but I want to build and test it too, to make sure my changes make sense. Thus ideally, if you can correct the master branch and let me know, then I'll rebase this merge request (or I'll recreate it, I do not know how it the rebase would break things under the hood).

By the way, how would you plan to do it with the libecal-2.0? Is the gnome-3-28 branch unsuitable for it? I suppose it is, thus you might consider a new release once these things land in the eds, maybe?

For a reference an e-mail about the upcoming changes: https://mail.gnome.org/archives/desktop-devel-list/2019-April/msg00016.html

Fixes https://gitlab.gnome.org/GNOME/gnome-todo/issues/249

Edited by Georges Basile Stavracas Neto

Merge request reports