Skip to content

inputcapture: Fix incorrect usage of g_string_equal()

Sid requested to merge sid/xdg-desktop-portal-gnome:g_string_equal_fix into main

Fixes the following warning.

../src/inputcapturedialog.c: In function ‘set_app_id’:
../src/inputcapturedialog.c:93:34: warning: passing argument 1 of ‘g_string_equal’ from incompatible pointer type [-Wincompatible-pointer-types]
   93 |   if (app_id && !g_string_equal (app_id, ""))
      |                                  ^~~~~~
      |                                  |
      |                                  const char *
In file included from /usr/include/glib-2.0/glib/giochannel.h:36,
                 from /usr/include/glib-2.0/glib.h:56,
                 from /usr/include/glib-2.0/gobject/gbinding.h:30,
                 from /usr/include/glib-2.0/glib-object.h:24,
                 from /usr/include/glib-2.0/gio/gioenums.h:30,
                 from /usr/include/glib-2.0/gio/giotypes.h:30,
                 from /usr/include/glib-2.0/gio/gio.h:28,
                 from /usr/include/gio-unix-2.0/gio/gdesktopappinfo.h:26,
                 from ../src/inputcapturedialog.c:21:
/usr/include/glib-2.0/glib/gstring.h:82:59: note: expected ‘const GString *’ {aka ‘const struct _GString *’} but argument is of type ‘const char *’
   82 | gboolean     g_string_equal             (const GString   *v,
      |                                          ~~~~~~~~~~~~~~~~~^
../src/inputcapturedialog.c:93:42: warning: passing argument 2 of ‘g_string_equal’ from incompatible pointer type [-Wincompatible-pointer-types]
   93 |   if (app_id && !g_string_equal (app_id, ""))
      |                                          ^~
      |                                          |
      |                                          char *
/usr/include/glib-2.0/glib/gstring.h:83:59: note: expected ‘const GString *’ {aka ‘const struct _GString *’} but argument is of type ‘char *’
   83 |                                          const GString   *v2);
      |                                          ~~~~~~~~~~~~~~~~~^~
[97/97] Linking target src/xdg-desktop-portal-gnome

Merge request reports