netbsd patches
While researching #2574 (closed), I looked at the rest of the netbsd patches in https://github.com/NetBSD/pkgsrc/tree/trunk/x11/vte3/patches ; I'd like to upstream as much of it as possible/makes sense.
-
patch-bindings_vala_app.vala: obsolete since the vala test app was removed.
-
patch-meson.build: The
_NETBSD_SOURCE
part is already on master/0-70. The symbol check part is wrong obviously since this symbol is required. If the test fails butTIOCGWINSZ
is available, I'd like to see the meson log why the test fails so as to fix it. -
patch-src_app_app.cc, patch-src_dumpkeys.c, patch-src_mev.c: These 3 area all sunos patches; why are they in netbsd? Anyway, if sunos doesn't have
cfmakeraw
, should add an implementation of that tomissing.{hh,cc}
instead of copypasting the code in 3 places. -
patch-src_meson.build: This is wrong. The
vte.sh
script is not an "example"; it is required to be called at shell startup. Is there a different location on netbsd where a script installed there will automatically be sourced for each interactive (whether login or non-login) shell on startup? -
patch-src_missing.cc: this is #2574 (closed)
-
patch-src_pty.cc: I don't get what this is trying to do. The only way that setting
need_nonblocking=true
here makes a difference would be ifposix_openpt(O_RDWR | O_NOCTTY | O_NONBLOCK | O_CLOEXEC)
succeeded but didn't actually apply theO_NONBLOCK
flag. Is that what happens here? -
patch-src_widget.cc: From https://nxr.netbsd.org/ I see that
W_EXITCODE
is guarded by_NETBSD_SOURCE
, so adding that define as master/0-70 already does should take care of this patch.
(Also the gnome-terminal patches in netbsd ports should now be obsolete on master/3-46.)
/cc @dhgutteridge