Reland "lib: Rework how vte stores the match and search regexes"
Hi, I reverted "lib: Rework how vte stores the match and search regexes" because it broke the build and you have no CI so I couldn't easily test a quick fix. Error is:
../src/vte.cc:949:1: error: declaration of ‘void vte::terminal::Terminal::regex_match_remove(int) noexcept’ has a different exception specifier
949 | Terminal::regex_match_remove(int tag) noexcept
| ^~~~~~~~
In file included from ../src/vte.cc:37:
../src/vteinternal.hh:1130:14: note: from previous declaration ‘void vte::terminal::Terminal::regex_match_remove(int)’
1130 | void regex_match_remove(int tag);
| ^~~~~~~~~~~~~~~~~~
../src/vte.cc:10786:1: error: declaration of ‘bool vte::terminal::Terminal::search_set_regex(vte::base::RefPtr<vte::base::Regex>&&, uint32_t)’ has a different exception specifier
10786 | Terminal::search_set_regex (vte::base::RefPtr<vte::base::Regex>&& regex,
| ^~~~~~~~
In file included from ../src/vte.cc:37:
../src/vteinternal.hh:1183:14: note: from previous declaration ‘bool vte::terminal::Terminal::search_set_regex(vte::base::RefPtr<vte::base::Regex>&&, uint32_t) noexcept’
1183 | bool search_set_regex(vte::base::RefPtr<vte::base::Regex>&& regex,
| ^~~~~~~~~~~~~~~~
Probably it would suffice to add noexcept to the declaration of regex_match_remove() at vteinternal.hh:1130. But I didn't want to try pushing that without project CI to know whether that's the only error.