Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • vala vala
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 770
    • Issues 770
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 73
    • Merge requests 73
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • valavala
  • Merge requests
  • !158

Add g_assert_cmp*() to glib-2.0.vapi (#395)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Chris White requested to merge cxw42/vala:issue395c into master Nov 26, 2020
  • Overview 17
  • Commits 2
  • Pipelines 0
  • Changes 3
  • Expose the existing GLib detailed-assertion comparisons to Vala code.
  • Add a GLib.Cmp namespace with constants representing the operators used with those functions, e.g., Glib.Cmp.LT === <.

Fixes #395 (closed).

I wasn't sure which directory to put the test code in, so I picked the one that seemed closest. The tests are in tests/basic-types/issue395.vala. Let me know if that file should be somewhere else.

I do not currently have tests for assert_cmpfloat_with_epsilon() or assert_cmpvariant() since I'm not sure of the right way to handle those in a platform-independent fashion. Ideas welcome!

Thanks for considering this MR!

Edited Nov 26, 2020 by Chris White
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: issue395c