gst_value_deserialize takes an `out value`, but should take a `ref value`.
Gst.Value.deserialize() is described in the VAPI as taking an out dest
:
[CCode (cheader_filename = "gst/gst.h")]
public static bool deserialize (out GLib.Value dest, string src);
However, it shoud actually be a ref dest
. See upstream, which shows dest
in the gtkdoc as:
* @dest: (out caller-allocates): #GValue to fill with contents of
* deserialization
(The caller has to allocate dest
because deserialize()
uses the type of dest
to decide how to interpret the src
string.)
What is the best way to fix this? I am happy to submit a one-line MR changing the .vapi, but I don't know if this would be better handled by make gstreamer-1.0 -C vapi
or metadata. I see that gstreamer-1.0.vapi
is autogenerated, so I am guessing one of the latter two. Please let me know. Thanks!
Edited by Chris White