Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • totem totem
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 191
    • Issues 191
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • totemtotem
  • Issues
  • #553
Closed
Open
Issue created Nov 28, 2022 by Krifa75@Krifa75Contributor

Update some base class

In Gtk4, multiple widgets can't be used as a base class anymore. Unfortunately, Totem use some of them.

Class Base class Possible solution
TotemMainToolbar HdyHeaderBar Really not sure : Split Header between player page and grilo page
TotemSelectionToolbar GtkActionBar Move it to totem-grilo
BaconVideoWidget GtkOverlay Use GtkBin
BaconTimeLabel GtkLabel Maybe create a class like bacon/totem_media_controllers to move the contollers inside it since it uses GtkToolItem which has been dropped in Gtk4.
Skipto : totem-time-entry GtkSpinButton Maybe move it inside totem-skipto

Thanks

Edited Nov 28, 2022 by Krifa75
Assignee
Assign to
Time tracking